Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed using move_and_slide with stop_on_slope stopping too early #24046

Merged
merged 1 commit into from Dec 14, 2018
Merged

Fixed using move_and_slide with stop_on_slope stopping too early #24046

merged 1 commit into from Dec 14, 2018

Conversation

Piet-G
Copy link
Contributor

@Piet-G Piet-G commented Nov 29, 2018

This makes it stop exactly on the slope, I'm not 100% sure if this if this is the correct fix let me know what you think.

Fixes #23675

This makes it stop exactly on the slope, I'm not 100% sure if this if this is the correct fix let me know what you think.

Fixes #23675
@Chaosus Chaosus added this to the 3.1 milestone Nov 29, 2018
@akien-mga akien-mga requested a review from reduz December 6, 2018 12:55
@akien-mga
Copy link
Member

13:55 <reduz> the fix could actually work
13:55 <reduz> it's pretty smart
13:56 <reduz> not sure if it will have side effects
13:56 <reduz> but it's well thought
13:56 <reduz> i would merge and see what happens

@akien-mga akien-mga merged commit 661e5e8 into godotengine:master Dec 14, 2018
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using stop_on_slope with move_and_slide will cause is_on_floor to return wrong results.
3 participants