Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EDITMODE_PRIORITY for ATLAS_TILE #24560

Merged
merged 1 commit into from Jun 1, 2019

Conversation

guilhermefelipecgs
Copy link
Member

@guilhermefelipecgs guilhermefelipecgs commented Dec 22, 2018

Fix #24549.
Now it's possible to randomize ATLAS_TILE based on defined priority.
peek 22-12-2018 21-48

@guilhermefelipecgs guilhermefelipecgs changed the title Add EDITMODE_PRIORITY for ATLAS_TILE [WIP] Add EDITMODE_PRIORITY for ATLAS_TILE Dec 23, 2018
@CowThing
Copy link
Contributor

How does this work with _forward_subtile_selection in GDScript? It looks like there's now two methods with the same name but different arguments?

@guilhermefelipecgs guilhermefelipecgs changed the title [WIP] Add EDITMODE_PRIORITY for ATLAS_TILE Add EDITMODE_PRIORITY for ATLAS_TILE Dec 23, 2018
@guilhermefelipecgs
Copy link
Member Author

Unfortunately gdscript will not accept two methods with the same name and different signatures, then I changed for _forward_atlas_subtile_selection.

When editing ATLAS_TILE, now it's possible to enable priority to
randomize subtiles.
@txigreman
Copy link

Maybe what I'm going to say it's stupid, but could "atlas tiles with priority" be implemented as autotiles with a 1x1 bitmask? Would that help to avoid having duplicated logic in different tile types?

@guilhermefelipecgs
Copy link
Member Author

Autotile with 1x1 bitmask doesn't make sense. AFAIK, the only way to get the same result using autotile is using the new wildcard feature #27565 with 3x3 bitmask and setting the center bitmask to on and all corners to wildcard.

Would that help to avoid having duplicated logic in different tile types?

I don't understand why you think the logic is duplicated. Atlastile don't have bitmask, so, the code is a little different.

@insomnius
Copy link

I really need this.

@akien-mga akien-mga merged commit 4b39903 into godotengine:master Jun 1, 2019
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tile type for selecting a random tile from an atlas without auto tiling.
8 participants