Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exported property values being lost if base GDScript fails to parse #25866

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

neikeq
Copy link
Contributor

@neikeq neikeq commented Feb 14, 2019

Fixes #25121

@neikeq
Copy link
Contributor Author

neikeq commented Feb 14, 2019

There is still an issue:

  • Make the base script fail to build/parse.
  • Restart the editor (maybe re-opening the scene is enough, I don't know)
  • Fix the build/parse error in the base script

The properties are still not showing in the inspector until the derived script is saved again. Nothing is lost though, so at least it's not critical.
Not sure if this is caused by the fallback or not. It doesn't happen in 3.0.0. This stuff is pretty hard to debug :(

@akien-mga akien-mga merged commit 89ca156 into godotengine:master Feb 14, 2019
@akien-mga
Copy link
Member

Thanks!

The properties are still not showing in the inspector until the derived script is saved again. Nothing is lost though, so at least it's not critical.

Might be worth opening an issue about it so that we remember to investigate further, but it's indeed not critical anymore after this fix.

@neikeq
Copy link
Contributor Author

neikeq commented Feb 14, 2019

Done: #25881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants