Fixed pixel snap precision artifact #26567
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
comment on source code will help others in the future |
clayjohn
force-pushed
the
pixel_snap_artifact
branch
from
9b8db08
to
b804c49
Compare
|
@volzhs You are right. Added! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the thread for this issue. My first solution didn't work because it ended up offsetting the texture by an entire pixel. After some exploring I realized that the artifact looked just like a precision issue. Leading me to realize that all that was needed was to shift the pixel enough that it wouldn't move, but more than the minimum floating point precision.
Overall, the solution looks pretty hacky, but it works in both GLES2 and GLES3.
fixes #26467