Request Android record permission when needed

[marcelofg55]

Fixes #26506

[akien-mga]

Works perfectly on my phones (Xiaomi Pocophone F1 with Android 9 and Samsung Galaxy S3 with Android 7.1.2) with the Mic Record demo.

Starting the app triggers this permission request as expected:

Then the recording feature works. Subsequent runs don't re-require the permission.

[marcelofg55]

Awesome, thanks for the testing!

[akien-mga]

By chance this comment is correct now, but I guess in the future we might want to add support for more permissions in the same method, so maybe it should be removed/updated?

[marcelofg55]

I'll remove it

[akien-mga]

Similar to above comment, will this check also be relevant for other types of permissions? If so, it should probably be done the other way around?

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
	if (p_name.equals("RECORD_AUDIO")) {

or maybe even:

if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
	 // Not necessary, asked on install already
	return true;
}

if (p_name.equals("RECORD_AUDIO")) {

[marcelofg55]

Sound good, I'll change it

[akien-mga]

Could you add documentation for this method too since it's bound? Currently users might try to request all kinds of permissions using it, to find out that it doesn't work as they think.

[marcelofg55]

Alright :D

[akien-mga]

@BastiaanOlij Should be relevant for your work :)

[akien-mga]

Thanks!

[BastiaanOlij]

Beautiful! I'm going to redo the permissions logic for ARCore so it requests the camera permissions through this. I'll probably do a separate PR for just the camera permissions once I get my head around it.

[BastiaanOlij]

@marcelofg55, I'm trying to duplicate this for the camera, if i understand the changes correctly, you now call request permissions from the audio driver.
If permissions were previously given this returns true and the audio driver initialises.
If no permissions where previously given the dialog opens but since code continues we return false.
When the user accepts the permissions we get a signal from the OS which is handled in onRequestPermissionsResult but what I'm missing is how you now trigger the audio driver to initialize now that it can?

[marcelofg55]

@BastiaanOlij check this: https://github.com/godotengine/godot/blob/master/platform/android/java_glue.cpp#L1586
Basically onRequestPermissionsResult calls that function on java_glue.cpp and capture_start is called to initialize the audio input.