Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locales: Add some missing locale names #28599

merged 1 commit into from May 2, 2019


Copy link

akien-mga commented May 2, 2019

Those were not displaying in the editor drop down list because we have the <lang>.po translations and not the expected <lang>_<country> code for those.

There are a lot more which have only <lang>_<country> codes when they are country specific, so we'd need to either add <lang> codes, or write some logic to automatically fall back to the first <lang>_<country> match found when there is no <lang> locale (we currently have a fallback the other way around, so that e.g. my en_DK locale falls back to en).

@akien-mga akien-mga added this to the 3.2 milestone May 2, 2019
@akien-mga akien-mga requested a review from reduz as a code owner May 2, 2019
@akien-mga akien-mga merged commit 21e2419 into godotengine:master May 2, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@akien-mga akien-mga deleted the akien-mga:locale-names branch May 2, 2019

This comment has been minimized.

Copy link
Member Author

akien-mga commented Nov 12, 2019

Cherry-picked for 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.