Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "no depth test" and render_priority sorting #29132

Merged
merged 1 commit into from May 24, 2019

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented May 23, 2019

supercedes #29113

Fixes #29108 and fixes #27739.

In GLES3, instead of rendering the sky earlier, render the "no depth test" objects as part of alpha pass.

In GLES2, move the sky rendering after opaque pass, render "no depth test" objects as part of alpha pass. And use priority in alpha pass instead of sort key (which is only used in GLES3).

This was the fix that reduz prefers, as discussed on IRC.

@akien-mga
Copy link
Member

Thanks!

@clayjohn clayjohn deleted the sort_depth_fix branch July 8, 2019 01:53
@akien-mga
Copy link
Member

Cherry-picked for 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects with "No Depth Test" gets drawn behind the Sky. GLES3 Render Priority Ignored Under GLES2
3 participants