Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "no depth test" and render_priority sorting #29132

Merged
merged 1 commit into from May 24, 2019

Conversation

@clayjohn
Copy link
Contributor

clayjohn commented May 23, 2019

supercedes #29113

Fixes #29108 and fixes #27739.

In GLES3, instead of rendering the sky earlier, render the "no depth test" objects as part of alpha pass.

In GLES2, move the sky rendering after opaque pass, render "no depth test" objects as part of alpha pass. And use priority in alpha pass instead of sort key (which is only used in GLES3).

This was the fix that reduz prefers, as discussed on IRC.

@clayjohn clayjohn requested a review from reduz as a code owner May 23, 2019
@YeldhamDev YeldhamDev added this to the 3.2 milestone May 23, 2019
@akien-mga akien-mga merged commit da617b7 into godotengine:master May 24, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented May 24, 2019

Thanks!

@clayjohn clayjohn deleted the clayjohn:sort_depth_fix branch Jul 8, 2019
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Jul 17, 2019

Cherry-picked for 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.