Fix "no depth test" and render_priority sorting #29132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supercedes #29113
Fixes #29108 and fixes #27739.
In GLES3, instead of rendering the sky earlier, render the "no depth test" objects as part of alpha pass.
In GLES2, move the sky rendering after opaque pass, render "no depth test" objects as part of alpha pass. And use
priority
in alpha pass instead ofsort key
(which is only used in GLES3).This was the fix that reduz prefers, as discussed on IRC.