Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if skeleton texture is already allocated before reallocating #31470

Merged
merged 1 commit into from Aug 19, 2019

Conversation

clayjohn
Copy link
Member

Fixes: #31412

skeleton_allocate() is called every frame by skeleton.cpp. So the texture should be generated in skeleton_create() as it is in GLES3.

Code graciously donated by Gamblify.

@clayjohn clayjohn added this to the 3.2 milestone Aug 19, 2019
@clayjohn clayjohn requested a review from reduz as a code owner August 19, 2019 05:04
@akien-mga akien-mga merged commit e71cf83 into godotengine:master Aug 19, 2019
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.1.2.

@clayjohn clayjohn deleted the GLES2-skeleton-memory-leak branch November 17, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leak of VRAM and RAM when freeing a rigged 3d Model (GLES2)
2 participants