Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if skeleton texture is already allocated before reallocating #31470

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@clayjohn
Copy link
Contributor

clayjohn commented Aug 19, 2019

Fixes: #31412

skeleton_allocate() is called every frame by skeleton.cpp. So the texture should be generated in skeleton_create() as it is in GLES3.

Code graciously donated by Gamblify.

@clayjohn clayjohn added this to the 3.2 milestone Aug 19, 2019
@clayjohn clayjohn requested a review from reduz as a code owner Aug 19, 2019
@akien-mga akien-mga merged commit e71cf83 into godotengine:master Aug 19, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Aug 19, 2019

Thanks!

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Sep 27, 2019

Cherry-picked for 3.1.2.

@clayjohn clayjohn deleted the clayjohn:GLES2-skeleton-memory-leak branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.