Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to go back/forward script history by mouse buttons #32071

Closed
wants to merge 1 commit into from

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Sep 10, 2019

I think its nice QoL change for users which have mouses with additional buttons (X1, X2) :)

@Calinou
Copy link
Member

Calinou commented Sep 10, 2019

Note that these shortcuts may conflict with an eventual implementation of #16554 and #26272. We could bind those to keys instead, but it'd make the feature less convenient and harder to discover.

Still, I think having this is better than nothing 🙂

@Chaosus
Copy link
Member Author

Chaosus commented Sep 10, 2019

We could bind those to keys instead

Why not do both ? Unfortunately seems like editor shortcuts cannot be binded to mouse.

@Calinou
Copy link
Member

Calinou commented Sep 10, 2019

@Chaosus I didn't realize it was possible to implement both on the same shortcut. Sounds good to me then.

And yes, the shortcut will have to be hardcoded for now since it uses mouse buttons.

@aaronfranke
Copy link
Member

Hopefully this is optional, I use my extra mouse buttons for push-to-talk in programs like Discord, it would be a shame if I could no longer talk while editing code in Godot. I'm assuming that "script history" means undo/redo history.

@Zylann
Copy link
Contributor

Zylann commented Sep 10, 2019

I like this idea, I use the Previous mouse button a lot (the one further away from the thumb) now that i discovered it does that in most code editors^^
I use the Next mouse button for push to talk as well (the one closest to the thumb), so I agree it should be optional, but it's still a really handy shortcut.

Btw how wo we know which of the XBUTTON is which? I'd expect the further one is Previous and the closer one is Next.

@Chaosus
Copy link
Member Author

Chaosus commented Sep 10, 2019

"script history" means undo/redo history.

This means pressing these buttons

image

my extra mouse buttons for push-to-talk in programs like Discord

These hotkeys reacts only if the cursor within script window

@Chaosus
Copy link
Member Author

Chaosus commented Sep 10, 2019

Sure, I can make a setting which disabling this behavior - how to name it ?

@BeayemX
Copy link
Contributor

BeayemX commented Sep 10, 2019

Could this also be extended to work with the inspector history (#19772) and maybe within the file system dock?

@aaronfranke
Copy link
Member

"Use forward and back mouse buttons" would be my suggestion. I would want such a setting to globally disable their usage, including if #16554, #19772, and/or #26272 use them.

@Chaosus
Copy link
Member Author

Chaosus commented Sep 10, 2019

Meh, I'm to bored to make this PR properly

@Chaosus Chaosus closed this Sep 10, 2019
@Chaosus Chaosus deleted the history_input branch September 10, 2019 18:24
@aaronfranke
Copy link
Member

Probably worth assigning the "salvageable" tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants