Add disabled theme icons for CheckBox

[KoBeWi]

Resolves #8640

HOWEVER I have no idea how to optimize the new images, so if anyone could advise what to use it would be nice >_>

[Calinou]

HOWEVER I have no idea how to optimize the new images, so if anyone could advise what to use it would be nice >_>

I use oxipng (typically) or sometimes OptiPNG with the following options:

# For small images. Zopfli optimization (`-Z`) results in better compression.
oxipng -Zso6 image.png
# or:
optipng -o6 -zm1-9 -strip all image.png

# For large images. Zopfli is slow to compress on large images, so it'd take too long to be usable.
oxipng -so6 image.png
# or:
optipng -o6 -strip all image.png

We could add Imgbot to the Godot repositories to perform this automatically.

[KoBeWi]

Ok, images optimized.

[Calinou]

The default project theme will likely be overhauled for 4.0, but this is a good change in the meantime that can be cherry-picked to the 3.x branch after 3.3 is released.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.4.

[Deozaan]

I just updated my project from 3.3.4 to 3.4 and this broke things for me. I'm using a custom theme based off the Editor theme, and it seems the Editor theme was not updated for 3.4 to include the new disabled icons.

So now I have mismatched icons when disabling/enabling any CheckBox nodes.

Because the Editor theme doesn't have the disabled icons, I can't just import them into my theme.

Meanwhile, the default theme of course does have them.

[Zireael07]

@Deozaan: There were enough changes in EditorTheme that your best bet is probably to reexport the theme anew.

[KoBeWi]

@Deozaan You can find these icons under EditorIcons group in the editor theme. They are called GUIChecked/UncheckedDisabled.

[Deozaan]

There were enough changes in EditorTheme that your best bet is probably to reexport the theme anew.

@Zireael07 That's probably a good idea, but I don't see how that will help with the missing icons.

You can find these icons under EditorIcons group in the editor theme. They are called GUIChecked/UncheckedDisabled.

@KoBeWi I don't see them.

[KoBeWi]

You are right, they only exist in 4.0. They were added in #51722 and never backported. I opened an issue: #54742

In the meantime, if you need to use these icons, you can get them here:
https://github.com/godotengine/godot/blob/master/editor/icons/GuiRadioCheckedDisabled.svg
https://github.com/godotengine/godot/blob/master/editor/icons/GuiRadioUncheckedDisabled.svg
https://github.com/godotengine/godot/blob/master/editor/icons/GuiCheckedDisabled.svg
https://github.com/godotengine/godot/blob/master/editor/icons/GuiUncheckedDisabled.svg

[Deozaan]

Thank you!