New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulkan: Make validation layers optional #42361
Conversation
da2c836
to
a89f17d
Compare
Quick discussion on IRC yesterday:
So it sounds like most of this code could actually be removed. I'll have to do some testing and dive back into the Vulkan tutorial to figure out how to test env-enabled validation layers. |
a89f17d
to
7fe2683
Compare
Regarding the previous comment, Instead, I moved this to a command line option Note that currently the engine crashes on cleanup when not using layers, that's a separate bug exposed by this PR which needs to be fixed. Stacktrace:
|
They're now disabled by default, and can be enabled with the command line argument `--vk-layers`. When enabled, the errors about them being missing are now warnings, as users were confused and thought this meant Vulkan is broken for them. Fix crash in `~VulkanContext` when validation layers are disabled (exposed by this PR since before they could not be disabled without source modification). Also moved VulkanContext member initializations to header. Fixes godotengine#37102.
7fe2683
to
54e6338
Compare
Fixed the crash mentioned above. |
They're now disabled by default, and can be enabled with the command line
argument
--vk-layers
.When enabled, the errors about them being missing are now warnings, as
users were confused and thought this meant Vulkan is broken for them.
Fix crash in
~VulkanContext
when validation layers are disabled (exposed bythis PR since before they could not be disabled without source modification).
Also moved VulkanContext member initializations to header.
Fixes #37102.