Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Fix splash screen loading on Android #42389

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Sep 28, 2020

Fix issue #21824

This is done by leveraging the Android theme to setup the app splash screen (reference).

Note:

  • The splash screen fullsize and use filter parameters are not supported due to limitations of the Android theme api
  • The PR is made against the 3.2-android-app-bundle branch since that branch includes numerous updates to the Android build process.
  • The feature targets the Godot 3.2.4 release.

master PR

@m4gr3d m4gr3d added this to the 3.2 milestone Sep 28, 2020
@m4gr3d m4gr3d requested review from akien-mga and a team September 28, 2020 18:28
@akien-mga akien-mga merged commit 1f16992 into godotengine:3.2 Sep 28, 2020
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_splash_loading_3_2 branch October 6, 2020 04:43
@NightBreather
Copy link

NightBreather commented Nov 20, 2020

I have a problem with it unfortunately sometimes the splashscreen doesn't look like it should. Sometimes it shows twice.How should i use this feature

@akien-mga
Copy link
Member

Please file a dedicated bug report.

@NightBreather
Copy link

NightBreather commented Nov 20, 2020

Please file a dedicated bug report.

I couldn't understand very much what kind of error report you are talking about. It is not a recurring situation but when opening the application, sometimes my png file appears again after it has appeared once.

The source code I used to try 👍

https://s4.dosya.tc/server12/nwqmh5/circle_jump-master.rar.html

I'm using a png logo in here

Godot 3.2.4 Beta 2

@akien-mga
Copy link
Member

I mean that it's more convenient for us if you create a new issue with all the information asked for in the issue template: https://github.com/godotengine/godot/issues/new?assignees=&labels=&template=bug_report.md&title=

Having one issue for each bug enables us to focus on debugging each issue separately, and eventually fixing them. This here is a merged Pull Request, and while it might be related to your issue (as it aimed to fix a similar problem), it may also not be.
So an actual bug report (issue) would be better (but you can reference this PR by its name: #42389 for additional context).

@NightBreather
Copy link

I mean that it's more convenient for us if you create a new issue with all the information asked for in the issue template: https://github.com/godotengine/godot/issues/new?assignees=&labels=&template=bug_report.md&title=

Having one issue for each bug enables us to focus on debugging each issue separately, and eventually fixing them. This here is a merged Pull Request, and while it might be related to your issue (as it aimed to fix a similar problem), it may also not be.
So an actual bug report (issue) would be better (but you can reference this PR by its name: #42389 for additional context).

thanks for information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants