Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made toplevel a property for Node3D and CanvasItem #42448

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Made toplevel a property for Node3D and CanvasItem #42448

merged 1 commit into from
Oct 1, 2020

Conversation

Duroxxigar
Copy link
Contributor

@Duroxxigar Duroxxigar commented Oct 1, 2020 •
edited by akien-mga

Fixes #10453.

@Duroxxigar Duroxxigar requested a review from a team as a code owner October 1, 2020 06:46
@Duroxxigar Duroxxigar mentioned this pull request Oct 1, 2020
Closed
@Duroxxigar
Copy link
Contributor Author

Duroxxigar commented Oct 1, 2020 •
edited

Made a mistake for working late on #36092 - my apologies. Felt like it would take longer to fix that one rather than open a new one in my current delirious state. I opted to not include information about the issue Akien linked in the other due to it not being reproducible as of yet. #24154

@akien-mga

@aaronfranke
Copy link
Member

As mentioned in #16863, this should likely be renamed to top_level.

@aaronfranke aaronfranke added this to the 4.0 milestone Oct 1, 2020
@akien-mga akien-mga merged commit cbcec0d into godotengine:master Oct 1, 2020
@akien-mga
Copy link
Member

Thanks!

As mentioned in #16863, this should likely be renamed to top_level.

That can be done in a second step, for this PR I prefer not to break compat so it can be cherry-picked.

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 1, 2020
@Duroxxigar Duroxxigar deleted the toplevel-as-property branch October 1, 2020 07:21
@aaronfranke aaronfranke mentioned this pull request Oct 1, 2020
Merged
@akien-mga
Copy link
Member

akien-mga commented Oct 1, 2020 •
edited

Cherry-picked for 3.2.4.
Edit: Reverted.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 1, 2020
@capnm capnm mentioned this pull request Oct 8, 2020
Closed
@akien-mga
Copy link
Member

Cherry-picked reverted to fix regression #42545.

The change is still there in the master branch, but might also trigger similar issues, which need to be debugged.

@foxydevloper foxydevloper mentioned this pull request Jul 24, 2021
Closed
@Calinou Calinou mentioned this pull request Sep 1, 2021
Closed
@Calinou Calinou mentioned this pull request Jun 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

set_as_toplevel() could be exposed to property
3 participants
@Duroxxigar @aaronfranke @akien-mga