Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2] [iOS] Port 4.0 changes #42582

Merged
merged 2 commits into from
Oct 7, 2020
Merged

[3.2] [iOS] Port 4.0 changes #42582

merged 2 commits into from
Oct 7, 2020

Conversation

naithar
Copy link
Contributor

@naithar naithar commented Oct 5, 2020

A follow-up commit for #42459

Ports master branch changes and project structure to make future PRs easier to port/cherry-pick.
Also implements ARC to simplify memory management for 3.2

Also fixes #36628 in 3.2 which was fixed in master on Vulkan support.

@naithar naithar requested a review from neikeq as a code owner October 5, 2020 21:16
@naithar
iOS: Refactor platform code
2bdfec2 
Change project structure to be more like 4.0
Refactor and remove old code as followup after deprecations fix
@naithar
iOS: port ARC support
5d12842
@Calinou Calinou added this to the 3.2 milestone Oct 5, 2020
@naithar
Copy link
Contributor Author

naithar commented Oct 7, 2020

Retested with release, release_debug and debug target and Instruments app.
Haven't found any leaks or crashes on cleanup/app termination.
Also tested ARKit module and haven't found any issues.

@akien-mga akien-mga requested a review from bruvzg October 7, 2020 09:52
@akien-mga akien-mga merged commit 4040cd3 into godotengine:3.2 Oct 7, 2020
@akien-mga
Copy link
Member

Thanks!

@naithar naithar mentioned this pull request Oct 31, 2020
Open
This was referenced Jan 12, 2021
Closed
Merged
@naithar naithar mentioned this pull request Feb 3, 2021
Closed
@naithar naithar deleted the feature/3.2-arc-refactor branch February 9, 2021 08:33
@naithar naithar mentioned this pull request Mar 1, 2021
Closed
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

@neikeq neikeq Awaiting requested review from neikeq

Assignees
No one assigned
Labels
enhancement platform:ios topic:porting
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@naithar @akien-mga @bruvzg @Calinou