Allow using SVG images as project icon #43369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since exporters will save their own icon, the target platforms don't have to support SVG to display the icon correctly. This closes godotengine#23068.
Calinou
added
cherrypick:3.x
I think at least Android uses the project icon by default, so this should likely be tested to confirm that it works. |
akien-mga
approved these changes
Nov 10, 2020
|
Thanks! |
|
May I suggest to include this small tweak also into 3.2.4, if it's possible? It should be pretty easy to port(one small change into main.cpp) and shouldn't break anything. |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since exporters will save their own icon, the target platforms don't have to support SVG to display the icon correctly.
In the future, we could consider supporting SVG favicons in the HTML5 export (whose support is quite good). This would require two things:
favicon.svgand reference it in the HTML.This closes #23068.
Preview