Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] VisualServer now sorts based on AABB position #43506

Merged
merged 1 commit into from
May 22, 2021

Conversation

QbieShay
Copy link
Contributor

@QbieShay QbieShay commented Nov 13, 2020

this was causing issues with scenes where the origin of the objects
was set for all objects to the center of the scene, making transparent
objects sort improperly

This work was kindly sponsored by IMVU

Co-authored-by: RevoluPowered gordon@gordonite.tech

@Calinou Calinou added this to the 3.2 milestone Nov 13, 2020
@akien-mga akien-mga changed the title visual server now sorts based on aabb position [3.2] visual server now sorts based on aabb position Nov 16, 2020
@akien-mga
Copy link
Member

Cross-referencing the master PR: #43507.

@akien-mga akien-mga changed the title [3.2] visual server now sorts based on aabb position [3.2] VisualServer now sorts based on AABB position Feb 25, 2021
@akien-mga
Copy link
Member

So if I understood correctly the plan for #43507 ended up being to merge it for 3.2 only, so I guess this 3.2 PR should be amended to do things like #43507 ended up doing it?

this was causing issues with scenes where the origin of the objects
was set for all objects to the center of the scene, making transparent
objects sort improperly

This work was kindly sponsored by IMVU

Co-authored-by: RevoluPowered <gordon@gordonite.tech>
@QbieShay
Copy link
Contributor Author

QbieShay commented Mar 5, 2021

Ok I know that this took ages and I'm sorry. But it's now made to match 4.0's PR :)

Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would consider waiting till after 3.2.4 stable to merge as there is a minor risk of regressions.

Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Mar 17, 2021
@akien-mga akien-mga changed the title [3.2] VisualServer now sorts based on AABB position [3.x] VisualServer now sorts based on AABB position Mar 26, 2021
@akien-mga akien-mga modified the milestones: 3.3, 3.4 Mar 26, 2021
@Calinou
Copy link
Member

Calinou commented May 21, 2021

Could we try to merge this for 3.3.2? I see frequent support requests about people struggling with transparency sorting issues that other engines can manage just fine. While transparency sorting is a difficult topic, there shouldn't be any issues with transparent materials that do not overlap with each other and are placed far away from each other.

@lawnjelly
Copy link
Member

Could we try to merge this for 3.3.2? I see frequent support requests about people struggling with transparency sorting issues that other engines can manage just fine. While transparency sorting is a difficult topic, there shouldn't be any issues with transparent materials that do not overlap with each other and are placed far away from each other.

Sure, sorry I wasn't too clear, I just meant above that having it go through at least a beta might be a good idea. For instance if it works fine on 3.4 beta 1, then cherry pick for 3.3 etc. 👍

@akien-mga akien-mga merged commit 4100a80 into godotengine:3.x May 22, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants