-
-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] VisualServer now sorts based on AABB position #43506
Conversation
a7a3660
to
a94c37b
Compare
Cross-referencing the |
this was causing issues with scenes where the origin of the objects was set for all objects to the center of the scene, making transparent objects sort improperly This work was kindly sponsored by IMVU Co-authored-by: RevoluPowered <gordon@gordonite.tech>
Ok I know that this took ages and I'm sorry. But it's now made to match 4.0's PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would consider waiting till after 3.2.4 stable to merge as there is a minor risk of regressions.
Could we try to merge this for 3.3.2? I see frequent support requests about people struggling with transparency sorting issues that other engines can manage just fine. While transparency sorting is a difficult topic, there shouldn't be any issues with transparent materials that do not overlap with each other and are placed far away from each other. |
Sure, sorry I wasn't too clear, I just meant above that having it go through at least a beta might be a good idea. For instance if it works fine on 3.4 beta 1, then cherry pick for 3.3 etc. 👍 |
Thanks! |
Cherry-picked for 3.3.3. |
this was causing issues with scenes where the origin of the objects
was set for all objects to the center of the scene, making transparent
objects sort improperly
This work was kindly sponsored by IMVU
Co-authored-by: RevoluPowered gordon@gordonite.tech