Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "font_color_separator" theme property to 'PopupMenu' #44070

Merged

Conversation

YeldhamDev
Copy link
Member

As it stands, the font color for labeled separators will always be the same for disabled items. With this new theme property, it can be set to anything else.

I also took the liberty to add a little more info to the add_separator() method doc as well.

@YeldhamDev YeldhamDev added enhancement documentation cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:gui labels Dec 3, 2020
@YeldhamDev YeldhamDev added this to the 4.0 milestone Dec 3, 2020
@YeldhamDev YeldhamDev requested a review from a team as a code owner December 3, 2020 14:43
@akien-mga akien-mga merged commit 67259d0 into godotengine:master Dec 10, 2020
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the popupmenu_separator_font_color branch December 10, 2020 11:16
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants