-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change themes font_color_selected to font_selected_color #44194
Change themes font_color_selected to font_selected_color #44194
Conversation
doc/classes/CodeEdit.xml
Outdated
@@ -181,7 +181,7 @@ | |||
</theme_item> | |||
<theme_item name="font_color_readonly" type="Color" default="Color( 0.88, 0.88, 0.88, 0.5 )"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was likely added later on to match the font_color_*
construct, but it should likely be renamed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to also rename:
font_color_accel
->font_accelerator_color
font_color_bg
->font_unselected_color
font_color_disabled
->font_disabled_color
font_color_fg
->font_selected_color
font_color_hover
->font_hover_color
font_color_hover_pressed
->font_hover_pressed_color
font_color_pressed
->font_pressed_color
font_color_readonly
->font_readonly_color
font_color_shadow
->font_shadow_color
font_color_uneditable
->font_uneditable_color
font_outline_modulate
->font_outline_color
icon_color_disabled
->icon_disabled_color
icon_color_hover
->icon_hover_color
icon_color_hover_pressed
->icon_hover_pressed_color
icon_color_normal
->icon_normal_color
icon_color_pressed
->icon_pressed_color
tab_fg
->tab_selected
tab_bg
->tab_unselected
Note 1: I've renamed font_outline_modulate
-> font_outline_color
. However, let me know if it should remain font_outline_modulate
. My thoughts are that although it actually just modulates the outline colour, this name makes more sense and we can easily change the documentation to reflect that.
Note 2: I've changed fg
to selected
and bg
to unselected
, which apply to tabs, and better reflects what they refer to.
b57a3c9
to
533658b
Compare
533658b
to
62d731a
Compare
I'm not sure that it's worth it to change all color constants to make a single odd one consistent with the others - it feels like it should maybe be done the other way around. But let's see what others think about it. |
We discussed this quickly in PR review and nobody has a strong preference either way. |
@akien-mga I find the new names better, both for consistency and for the better naming in the case of the tab themes. |
@akien-mga I think the new names are better as well. |
I actually prefer old names, but the new ones are fine too. |
Changed: font_color_accel -> font_accelerator_color font_color_bg -> font_unselected_color font_color_disabled -> font_disabled_color font_color_fg -> font_selected_color font_color_hover -> font_hover_color font_color_hover_pressed -> font_hover_pressed_color font_color_pressed -> font_pressed_color font_color_readonly -> font_readonly_color font_color_selected -> font_selected_color font_color_shadow -> font_shadow_color font_color_uneditable -> font_uneditable_color icon_color_disabled -> icon_disabled_color icon_color_hover -> icon_hover_color icon_color_hover_pressed -> icon_hover_pressed_color icon_color_normal -> icon_normal_color icon_color_pressed -> icon_pressed_color Also includes: font_outline_modulate -> font_outline_color tab_fg -> tab_selected tab_bg -> tab_unselected
62d731a
to
8eb39f4
Compare
Rebased following merge of #45128. |
Thanks! |
To make it consistent with all the other
Theme
's color properties i.e. they end in color, this PR renamesfont_color_selected
tofont_selected_color
.Part of #16863.
Edit: Updated to include: