Change themes font_color_selected to font_selected_color #44194
Conversation
doc/classes/CodeEdit.xml
Outdated
| @@ -181,7 +181,7 @@ | |||
| </theme_item> | |||
| <theme_item name="font_color_readonly" type="Color" default="Color( 0.88, 0.88, 0.88, 0.5 )"> | |||
There was a problem hiding this comment.
This one was likely added later on to match the font_color_* construct, but it should likely be renamed too.
There was a problem hiding this comment.
Updated to also rename:
font_color_accel->font_accelerator_colorfont_color_bg->font_unselected_colorfont_color_disabled->font_disabled_colorfont_color_fg->font_selected_colorfont_color_hover->font_hover_colorfont_color_hover_pressed->font_hover_pressed_colorfont_color_pressed->font_pressed_colorfont_color_readonly->font_readonly_colorfont_color_shadow->font_shadow_colorfont_color_uneditable->font_uneditable_colorfont_outline_modulate->font_outline_coloricon_color_disabled->icon_disabled_coloricon_color_hover->icon_hover_coloricon_color_hover_pressed->icon_hover_pressed_coloricon_color_normal->icon_normal_coloricon_color_pressed->icon_pressed_colortab_fg->tab_selectedtab_bg->tab_unselected
Note 1: I've renamed font_outline_modulate -> font_outline_color. However, let me know if it should remain font_outline_modulate. My thoughts are that although it actually just modulates the outline colour, this name makes more sense and we can easily change the documentation to reflect that.
Note 2: I've changed fg to selected and bg to unselected, which apply to tabs, and better reflects what they refer to.
madmiraal
force-pushed
the
fix-font_selected_color
branch
3 times, most recently
from
b57a3c9
to
533658b
Compare
madmiraal
force-pushed
the
fix-font_selected_color
branch
from
533658b
to
62d731a
Compare
|
I'm not sure that it's worth it to change all color constants to make a single odd one consistent with the others - it feels like it should maybe be done the other way around. But let's see what others think about it. |
|
We discussed this quickly in PR review and nobody has a strong preference either way. |
|
@akien-mga I find the new names better, both for consistency and for the better naming in the case of the tab themes. |
|
@akien-mga I think the new names are better as well. |
|
I actually prefer old names, but the new ones are fine too. |
Changed: font_color_accel -> font_accelerator_color font_color_bg -> font_unselected_color font_color_disabled -> font_disabled_color font_color_fg -> font_selected_color font_color_hover -> font_hover_color font_color_hover_pressed -> font_hover_pressed_color font_color_pressed -> font_pressed_color font_color_readonly -> font_readonly_color font_color_selected -> font_selected_color font_color_shadow -> font_shadow_color font_color_uneditable -> font_uneditable_color icon_color_disabled -> icon_disabled_color icon_color_hover -> icon_hover_color icon_color_hover_pressed -> icon_hover_pressed_color icon_color_normal -> icon_normal_color icon_color_pressed -> icon_pressed_color Also includes: font_outline_modulate -> font_outline_color tab_fg -> tab_selected tab_bg -> tab_unselected
madmiraal
force-pushed
the
fix-font_selected_color
branch
from
62d731a
to
8eb39f4
Compare
|
Rebased following merge of #45128. |
|
Thanks! |
To make it consistent with all the other
Theme's color properties i.e. they end in color, this PR renamesfont_color_selectedtofont_selected_color.Part of #16863.
Edit: Updated to include: