Android: Add support for cursor icons

[thebestnom]

Adds support for cursor shapes on Android

Custom cursor shape is way harder, there need to be a way to move image from native to java by jni and I can't seem to find any way to do it, any help would be appriciated

I'll add a branch for 3.2 with #43249 together once this is ready

@m4gr3d

[thebestnom]

Anythinhg else on this? @m4gr3d

[m4gr3d]

The PR looks good. I've added a few pieces of feedback.

On the java side, the same logic is repeated both in the GodotGLRenderView and GodotVulkanRenderView. Move that logic into a helper class (e.g: GodotPointerIconHandler), and have both instances of GodotRenderView forward the necessary calls to that class instead.

Let's move support for custom cursor shape into another PR. From the look of the Android api, only passing Bitmap is supported for custom pointer icon. The Godot native api has a matching Bitmap resource class so we may be able to add a conversion utility between the two (and any other matching Godot resource types).

[thebestnom]

Let's move support for custom cursor shape into another PR. From the look of the Android api, only passing Bitmap is supported for custom pointer icon. The Godot native api has a matching Bitmap resource class so we may be able to add a conversion utility between the two (and any other matching Godot resource types).

Yeah, that what I was going to do

I already tried a way to convert native bitmap to java bitmap but jni didn't like that, the best way I can think of is sending bitmap as array, but Ill think of a way when well get there

For now Ill try to fix the code this week, thanks for the cr ☺️

[thebestnom]

@m4gr3d tried fixing the comment, while doing this I rebased buy it looks like android build stop working, trying to fix

[thebestnom]

looks like it's broken on master

[akien-mga]

Code looks good to me, is this ready to merge @thebestnom @m4gr3d?

[thebestnom]

Last time I tested that it worked, but I can't run master on phone for about 4 month (can't remember exactly) so I haven't tested that since

[thebestnom]

@akien-mga ok, finally could test today and looks like it is still working!

[m4gr3d]

@akien-mga ok, finally could test today and looks like it is still working!

Great! Are all the requested changes addressed?

[thebestnom]

@akien-mga ok, finally could test today and looks like it is still working!

Great! Are all the requested changes addressed?

Looked at the pr comments and the changes to refresh my memories and looks like I already addressed the comments, yep

[thebestnom]

ok, finally fixed static checks... I think this is ready for merge

[akien-mga]

Thanks!