[3.2] Fix fallback emoji font color.

[bruvzg]

Use the font face with the found char not the base one to detect color.

[akien-mga]

Should the other calls to FT_HAS_COLOR(face) get the same treatment?

scene/resources/dynamic_font.cpp
169:    if (FT_HAS_COLOR(face) && face->num_fixed_sizes > 0) {
309:            int error = FT_Load_Char(face, p_char, FT_HAS_COLOR(face) ? FT_LOAD_COLOR : FT_LOAD_DEFAULT);
329:                    if (FT_HAS_COLOR(face)) {
598:    int error = FT_Load_Char(face, p_char, FT_HAS_COLOR(face) ? FT_LOAD_COLOR : FT_LOAD_DEFAULT | (font->force_autohinter ? FT_LOAD_FORCE_AUTOHINT : 0) | ft_hinting);

[bruvzg]

No, draw_char and get_char_size are the only methods that are always called for base data instance and then accessing fallbacks. The rest are called for the fallback data directly.

[akien-mga]

This one is in draw_char though, used for the outline:

309:            int error = FT_Load_Char(face, p_char, FT_HAS_COLOR(face) ? FT_LOAD_COLOR : FT_LOAD_DEFAULT);

[akien-mga]

This is with this PR when using emoji font as main font:

[akien-mga]

This additional diff doesn't solve it though, might be more complex than that.

diff --git a/scene/resources/dynamic_font.cpp b/scene/resources/dynamic_font.cpp
index 7027660633..ac6798cc23 100644
--- a/scene/resources/dynamic_font.cpp
+++ b/scene/resources/dynamic_font.cpp
@@ -305,10 +305,10 @@ float DynamicFontAtSize::draw_char(RID p_canvas_item, const Point2 &p_pos, CharT
 
        // use normal character size if there's no outline character
        if (p_outline && !ch->found) {
-               FT_GlyphSlot slot = face->glyph;
-               int error = FT_Load_Char(face, p_char, FT_HAS_COLOR(face) ? FT_LOAD_COLOR : FT_LOAD_DEFAULT);
+               FT_GlyphSlot slot = font->face->glyph;
+               int error = FT_Load_Char(font->face, p_char, FT_HAS_COLOR(font->face) ? FT_LOAD_COLOR : FT_LOAD_DEFAULT);
                if (!error) {
-                       error = FT_Render_Glyph(face->glyph, FT_RENDER_MODE_NORMAL);
+                       error = FT_Render_Glyph(font->face->glyph, FT_RENDER_MODE_NORMAL);
                        if (!error) {
                                Character character = Character::not_found();
                                character = const_cast<DynamicFontAtSize *>(this)->_bitmap_to_character(slot->bitmap, slot->bitmap_top, slot->bitmap_left, slot->advance.x / 64.0);

[bruvzg]

I think it's how it should work, outlines do no work with bitmaps, and the aforementioned code is only for skipping bitmap character width when drawing an outline.

[akien-mga]

Sounds good, thanks for clarifying.

[bruvzg]

For the reference there's no outline for bitmaps emoji in master either (and embedded SVG emoji is not yet supported by freetype).

[akien-mga]

And we have this issue to keep track of it: #34870

[akien-mga]

For the reference (this was discussed on IRC but mentioning it here too), the issue was already fixed in the master branch as part of the CTL work / font refactoring.

[akien-mga]

Thanks!

[Cheeseness]

Many thanks!