[3.2] [HTML5] Editor style, audio fixes #44256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Dec 10, 2020
akien-mga
reviewed
Dec 10, 2020
Comment on lines
+28
to
+30
| BoolVariable("use_ubsan", "Use LLVM/GCC compiler undefined behavior sanitizer (UBSAN)", False), | ||
| BoolVariable("use_asan", "Use LLVM/GCC compiler address sanitizer (ASAN)", False), | ||
| BoolVariable("use_lsan", "Use LLVM/GCC compiler leak sanitizer (LSAN)", False), |
There was a problem hiding this comment.
Nitpick but in this case it can't be GCC I guess, it's Emscripten/LLVM.
There was a problem hiding this comment.
True, I copied it from other platforms.
And since it's like that in master now I would prefer leaving it like that for now (so I can keep them more in sync).
I'll try to remember to change it next time I PR some JS stuff that needs backporting.
Check emcc version requirements when building GDNative. Add more build options (sanitizers, initial memory).
Faless
force-pushed
the
js/3.x_editor_beta
branch
from
432b64e
to
0a67b23
Compare
akien-mga
approved these changes
Dec 10, 2020
|
Thanks! |
| GodotAudio.input = GodotAudio.ctx.createMediaStreamSource(stream); | ||
| callback(GodotAudio.input); | ||
| } catch (e) { | ||
| GodotRuntime.error('Failed creaating input.', e); |
There was a problem hiding this comment.
typo in "creaating"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.2version of #44221