Add a Dynamic BVH implementation. #44531
Conversation
reduz
force-pushed
the
add-dynamic-bvh
branch
from
daac86c
to
842d075
Compare
| DynamicBVH::Node *DynamicBVH::_node_sort(Node *n, Node *&r) { | ||
| Node *p = n->parent; | ||
| ERR_FAIL_COND_V(!n->is_internal(), nullptr); | ||
| if (p > n) { |
There was a problem hiding this comment.
Is this meant to compare the pointers or are we missing a comparison operator?
There was a problem hiding this comment.
Good catch, it appears to be like this on Bullet too, it does not make much sense to me, I wonder why is this done this way..
There was a problem hiding this comment.
bullet also allocates on heap, so I should assume it has some sort of meaning, but i really really cant figure it out.
There was a problem hiding this comment.
yup, I would expect the comparison to have some sort of geometric meaning...
There was a problem hiding this comment.
My wild guess is that it may be to avoid a redundant rotation or something like this, but the code is too cryptic. Maybe @lawnjelly knows?
There was a problem hiding this comment.
Maybe it's a variation of !=. It doesn't make much sense.
There was a problem hiding this comment.
Could it be related to cache efficiency? With this sorting the nodes closer to the root of the tree will end up closer in memory, and depending on the allocator they could even be in contiguous memory.
There was a problem hiding this comment.
It looks like this is just sorting nodes by memory address for cache optimization. It swaps parent and child completely, including their volumes so I don't think it has a geometric reason.
There was a problem hiding this comment.
Ah, I had missed the latest comment. I agree with this interpretation :)
-Based on Bullet Dbvh, has style and functional changes. -Provides efficient pairing -Needed to optimize rendering -Needed to optimize physics This PR is up for others to review the implementation.
reduz
force-pushed
the
add-dynamic-bvh
branch
from
842d075
to
5ff8993
Compare
|
I think that this PR should also contains tests, because seems that results will be mostly reproducible and this will prevent from regressions like in LocalVector - #40913 |
|
@qarmin I agree, though its difficult to think how tests for this could be created |
-Based on Bullet Dbvh, has style and functional changes.
-Helps achieve efficient pairing
-Needed to optimize rendering
-Needed to optimize physics