Rename Math::stepify to snapped #44586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmiraal
requested review from
aaronfranke,
BastiaanOlij,
vnen and
a team
as code owners
83 tasks
madmiraal
force-pushed
the
rename-stepify
branch
from
c0e6341
to
5d3e510
Compare
aaronfranke
requested changes
Dec 28, 2020
madmiraal
force-pushed
the
rename-stepify
branch
from
5d3e510
to
a685930
Compare
madmiraal
force-pushed
the
rename-stepify
branch
from
a685930
to
b743a2e
Compare
akien-mga
approved these changes
Dec 28, 2020
|
I haven't compiled/tested this but it looks good. All instances of |
|
Thanks! |
aaronfranke
added a commit
to aaronfranke/godot-cpp
that referenced
this pull request
Sep 18, 2022
aaronfranke
added a commit
to aaronfranke/godot-cpp
that referenced
this pull request
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As originally identified here, and as described in the @GDscript documentation,
Math::stepify()returns a snapped value. Furthermore, this is what it is called in theVector2andVector3versions that use this method. Therefore, this PR renamesMath::stepify()tostepped().Part of #16863.