Rewrite culling to be more cache/thread friendly. #44699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
commented
Dec 26, 2020
| Plane near_plane(p_cam_transform.origin, -p_cam_transform.basis.get_axis(Vector3::AXIS_Z)); | ||
| near_plane.d += p_cam_projection.get_z_near(); | ||
| float z_max = p_cam_projection.get_z_far() - p_cam_projection.get_z_near(); | ||
|
|
||
| uint32_t geometry_index = 0; | ||
|
|
||
| //fill list | ||
|
|
||
| for (int i = 0; i < (int)p_instances.size(); i++) { | ||
| InstanceBase *inst = p_instances[i]; | ||
|
|
There was a problem hiding this comment.
This code was moved here from cull. I am not sure why it was in there originally, as it makes more sense here.
reduz
force-pushed
the
cache-thread-friendly-culling
branch
2 times, most recently
from
d7b8a98
to
ae93dfc
Compare
clayjohn
reviewed
Dec 26, 2020
-Uses a single array with all data -Massive performance improvement -Does not support threads yet, but code is now thread friendly
reduz
force-pushed
the
cache-thread-friendly-culling
branch
from
ae93dfc
to
5485241
Compare
clayjohn
approved these changes
Dec 26, 2020
This was referenced Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Uses a single array with all data.
-Massive performance improvement (Ryzen 7, 10k objects, culling goes down from 4ms to 1.2ms).
-Does not support threads yet, but code is now thread friendly, so this should improve performance several times more eventually.