Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to not optimize release build #46966

Merged
merged 1 commit into from
Mar 20, 2021
Merged

Allow to not optimize release build #46966

merged 1 commit into from
Mar 20, 2021

Conversation

qarmin
Copy link
Contributor

@qarmin qarmin commented Mar 13, 2021

Fixes godotengine/godot-proposals#2457

This will allow to speedup compilation for people, that want to test Godot without DEBUG_ENABLED flag

If fix is good, then I will do the same for others platform

@qarmin qarmin requested a review from a team March 13, 2021 14:36
@qarmin qarmin requested a review from a team as a code owner March 13, 2021 14:36
@Chaosus Chaosus added this to the 4.0 milestone Mar 13, 2021
Xrayez
Xrayez reviewed Mar 13, 2021
View reviewed changes
platform/linuxbsd/detect.py Outdated Show resolved Hide resolved
Xrayez
Xrayez reviewed Mar 13, 2021
View reviewed changes
platform/linuxbsd/detect.py Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

Seems fine to me (with the changes suggested by @Xrayez), so you can apply it to other platforms.

@qarmin qarmin requested review from a team as code owners March 14, 2021 06:28
@qarmin qarmin force-pushed the faster_release branch 2 times, most recently from e2c9e9d to 432c321 Compare March 14, 2021 08:11
@qarmin qarmin added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 14, 2021
@qarmin
Copy link
Contributor Author

qarmin commented Mar 14, 2021

Compilation flags between 3.2 and 4.0 branch are very similar so I added cherrypick(probably only linuxbsd->x11 needs to be done).

I tested in 3.2 branch compilation times with default optimization and this took more than 4h in CI - https://github.com/qarmin/RegressionTestProject/pull/29/checks?check_run_id=2102453232
Probably after adding this commit, compilation times should go down to ~30min-1h

Calinou
Calinou approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we could extend this to editor builds to get fast compilation feedback (at the cost of very slow runtime performance).

@akien-mga akien-mga merged commit fcddd8c into godotengine:master Mar 20, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 20, 2021
@qarmin qarmin deleted the faster_release branch May 23, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xrayez Xrayez Xrayez left review comments

@Calinou Calinou Calinou approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:buildsystem
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Add fast compilation option for target=release
5 participants
@qarmin @akien-mga @Calinou @Xrayez @Chaosus