Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An to a in "CHANGELOG.md" #46975

Closed
wants to merge 1 commit into from
Closed

An to a in "CHANGELOG.md" #46975

wants to merge 1 commit into from

Conversation

MrBrain295
Copy link
Contributor

An to a in line 190 of "CHANGELOG.md".

An to a in line 190.
@Calinou Calinou added the bug label Mar 13, 2021
@akien-mga
Copy link
Member

I would prefer such typo/grammar changes to be batched together in a single commit. Whether you are going through the documentation and finding some typos among the way, or using a parsing tool to identify them, you can queue such changes locally and make a PR once there's a significant amount of fixes (see e.g. #46929).

Otherwise we'd end up with lots of PRs and lots of merged commits for single low-priority typo fixed, which makes the overall changelog of the very active development branch harder to parse to find actual engine code changes.

@MrBrain295 MrBrain295 marked this pull request as draft March 14, 2021 21:22
@MrBrain295 MrBrain295 marked this pull request as ready for review March 14, 2021 21:41
@dalexeev
Copy link
Member

@akien-mga Perhaps we need to allocate one issue for these needs. Create a typo and grammatical error tracker, in which everyone will add their corrections in the comments, and as they accumulate, one of the maintainers will commit the next portion and clear the topic after merging.

@akien-mga
Copy link
Member

For the reference, this typo fix is included in #47505. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants