Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make randomize() use unix time instead of ticks #48098

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Make randomize() use unix time instead of ticks #48098

merged 1 commit into from
Apr 23, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 22, 2021

Fixes #48087

@KoBeWi KoBeWi added bug topic:core cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 22, 2021
@KoBeWi KoBeWi added this to the 4.0 milestone Apr 22, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner April 22, 2021 15:20
akien-mga
akien-mga reviewed Apr 22, 2021
View reviewed changes
core/math/random_pcg.cpp Outdated Show resolved Hide resolved
Faless
Faless approved these changes Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@akien-mga akien-mga merged commit c04681b into godotengine:master Apr 23, 2021
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the you_never_know branch April 23, 2021 09:54
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 23, 2021
@madmiraal madmiraal mentioned this pull request May 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou left review comments

@Xrayez Xrayez Xrayez approved these changes

@Faless Faless Faless approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

randomize() often producing same seed when called in _ready()
5 participants
@KoBeWi @akien-mga @Calinou @Faless @Xrayez