[3.x] Backport non-breaking changes in the Theme resource from master
#49487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of relevant, non-breaking parts of godotengine#37759
Backport of relevant parts of godotengine#47251, godotengine#49308
Backported from godotengine#47544 where it was originally identified
YuriSizov
force-pushed
the
theme-utility-methods-3.x
branch
from
d2334da
to
fddd09d
Compare
YuriSizov
changed the title
Theme resource from masterTheme resource from master
akien-mga
approved these changes
Jun 11, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes has been ported:
Add missing type list methods (Remove unused argument in Theme method and expose missing methods #37759) (named
*_typesto followget_stylebox_types, renamed inmaster):Theme.get_color_types()(get_color_type_listinmaster)Theme.get_constant_types()(get_constant_type_listinmaster)Theme.get_font_types()(get_font_type_listinmaster)Theme.get_icon_types()(get_icon_type_listinmaster)Add utility methods with all fixes applied (Add utility methods to Theme, improve error messages and documentation #47251, Fix
Themeoverriding existing theme types with empty #49308):3.xWhile Add
theme_custom_typeproperty toControlandWindow#47544 is not portable due to compatibility breaking fixes, one fix can be ported as it is just a typo.All changes are split into individual commits related to each backported changeset/PR.