Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action_get_deadzone() method to InputMap #50065

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Add action_get_deadzone() method to InputMap #50065

merged 1 commit into from
Jul 2, 2021

Conversation

SirQuartz
Copy link
Contributor

@SirQuartz SirQuartz commented Jul 2, 2021

This pull request adds a new method to the InputMap class, allowing the user to get the value of an action's dead zone as a float.

Resolves: #50061

get_dead_zone script

get_dead_zone output

action_get_deadzone() method description

@SirQuartz SirQuartz requested a review from a team as a code owner July 2, 2021 04:06
@SirQuartz SirQuartz changed the title Add get_dead_zone() method to InputMap Add action_get_deadzone() method to InputMap Jul 2, 2021
@akien-mga
Copy link
Member

Looks good, but you need to run godot --doctool to also add the matching method in the class reference (and if you can write its description).

@akien-mga akien-mga added cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:input labels Jul 2, 2021
@akien-mga akien-mga added this to the 4.0 milestone Jul 2, 2021
@SirQuartz SirQuartz requested a review from a team as a code owner July 2, 2021 04:37
@SirQuartz
Copy link
Contributor Author

Looks good, but you need to run godot --doctool to also add the matching method in the class reference (and if you can write its description).

Ok, looks like everything is good now. 🙂

@akien-mga
Copy link
Member

Could you squash the commits? Note that this can't be done with the web UI, you'll have to use Git directly: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase

This commit adds a new method to the `InputMap`, allowing the user to get the value of an action's dead zone as a float.
@SirQuartz
Copy link
Contributor Author

Could you squash the commits? Note that this can't be done with the web UI, you'll have to use Git directly: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase

Done. Now everything should be fine.

@akien-mga akien-mga merged commit 276f256 into godotengine:master Jul 2, 2021
@akien-mga
Copy link
Member

Thanks!

@SirQuartz SirQuartz deleted the patch-1 branch July 2, 2021 09:07
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 5, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputMap has no action_get_deadzone() getter
2 participants