Try other resolved IPs if one fails to connect #50365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
cherrypick:3.3
cherrypick:3.x
Faless
requested changes
Aug 29, 2021
timothyqiu
force-pushed
the
ip-candidates
branch
from
a5dc3e7
to
fd52e18
Compare
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Edit: Undid cherry-pick, it requires |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
HTTPClientandWebSocketClientare connecting to server, save all resolved IPs, and try other candidates if one failed to connect. Not Happy Eyeballs, but at least it's happy I think :)Fixes #46972, and hopefully fixes #36418, I don't have IPv6 connection to the AssetLib, so I only tested on my
localhostwhich resolved to IPv6 first.It's the same for 3.x, but
core/io/http_client_tcp.{h,cpp}→core/io/http_client.{h,cpp}andcontainer.is_empty()→container.empty().