Clarify the purpose of the default asset library URLs in the editor #50768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.3
cherrypick:3.x
|
We can probably remove localhost by now, yes. |
`localhost` was removed as it won't work out of the box. It can be added by the user if they're working on the asset library itself. This won't affect existing installations due to how the editor settings are stored, but existing installations will keep working fine.
Calinou
force-pushed
the
editor-asset-library-urls-clarify
branch
from
4dfc7b0
to
eac8ba6
Compare
Done:
|
akien-mga
approved these changes
Jul 23, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localhostwas removed as it won't work out of the box. It can be added by the user if they're working on the asset library itself.This won't affect existing installations due to how the editor settings are stored, but existing installations will keep working fine.
Note: There's also the question of whether we should still list
localhostby default, since the editor asset library URLs can now be configured freely by the user. Most people won't be hosting their development server on port 80 since it requires root privileges.Preview
Old reversion of this PR