Fixes the normals of SphereMesh when the sphere/hemisphere is oblong #51995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:3d
topic:core
cherrypick:3.3
cherrypick:3.x
drcd1
force-pushed
the
sphere-mesh-normals-fix
branch
from
6bee83d
to
f4ac08a
Compare
|
I haven't double-checked the math, but assuming it's correct, do we need to fix tangents as well? |
In this case, the tangents are orthogonal to the scaling axis (i.e.: parallel to the xz plane) so they don't change when you scale along the y axis. |
JFonS
approved these changes
Aug 25, 2021
|
Edit: Reverted cherry-pick due to regression: #52965. |
akien-mga
removed
the
cherrypick:3.x
akien-mga
added
cherrypick:3.x
|
Cherry-picked for 3.4. (Together with #53154.) |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49861
Basic logic (in 2D) is that if
(a,b)is a normal, the corresponding tangent is(b,-a). If the object is scaled along the y axis, the tangent becomes(b,-a*scale). The normal to this tangent is therefore (a*scale, b).