Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AppImage structure #5241

Closed
wants to merge 1 commit into from
Closed

Conversation

djrm
Copy link
Contributor

@djrm djrm commented Jun 16, 2016

This will allow the distribution of AppImages for linux

Name=Godot Engine
Exec=godot %u
Icon=godot
Categories=Game development;Game engine;Games;Development
Copy link
Member

@akien-mga akien-mga Jun 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are not valid FreeDesktop categories.
I use this for Mageia:

[Desktop Entry]
Name=Godot Engine
GenericName=Libre game engine
Comment=Multi-platform 2D and 3D game engine with a feature rich editor
Exec=godot -pm
Icon=godot
Terminal=false
Type=Application
Categories=Development;IDE;

@akien-mga
Copy link
Member

akien-mga commented Jun 16, 2016

We really need to cleanup tools/, it's getting incredibly crowded :/
When this is merged, I'll move all distribution-related folders to their own subfolder.

@djrm
Copy link
Contributor Author

djrm commented Jun 16, 2016

Yes, you are right, i put the AppDir folder in tools becase i saw other folders like it there.

@reduz
Copy link
Member

reduz commented Jun 16, 2016

yeah, i suppose some of the osx/ios stuff could go to their respective
platforms

On Thu, Jun 16, 2016 at 1:07 PM, Daniel Ramirez notifications@github.com
wrote:

Yes, you are right, i put the AppDir folder in tools becase i saw other
folders like it there.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#5241 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AF-Z27x74ISYtYSKTVIshPs5iS5nBMNnks5qMXSxgaJpZM4I2_00
.

@akien-mga
Copy link
Member

I'll move stuff around, and then ask you to rebase accordingly :)

@djrm
Copy link
Contributor Author

djrm commented Jun 19, 2016

ok

@akien-mga akien-mga self-assigned this Jul 18, 2016
@akien-mga akien-mga added this to the 2.1 milestone Jul 18, 2016
@reduz
Copy link
Member

reduz commented Jul 24, 2016

feel free to merge if you find it works

@akien-mga akien-mga modified the milestones: 2.1, 2.2 Aug 10, 2016
@akien-mga
Copy link
Member

@djrm I finally did the tools cleanup I wanted, so if my PR (#6364) is merged in its current state, I'll ask you to move your appimage structure to tools/dist. But we'll see if others agree with this path first.

@@ -0,0 +1,3 @@
#!/bin/sh
HERE=$(dirname $(readlink -f "${0}"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always be careful with bash, this doesn't work for folders with spaces:

image

The correct command:

HERE="$(dirname "$(readlink -f "${0}")")"

@djrm
Copy link
Contributor Author

djrm commented Sep 1, 2016

@akien-mga ok, i will move this once your PR gets merged, @procedural, ok i will change before pushing this again.

@akien-mga
Copy link
Member

@djrm Should be good to rebase now :) Maybe rename the folder to something a bit clearer too (see the other examples in tools/dist, mentioning that it's Godot is maybe not necessary in the folder name).

@djrm
Copy link
Contributor Author

djrm commented Oct 4, 2016

ok, will check that out

@akien-mga akien-mga modified the milestones: 3.0, 2.2 Jan 10, 2017
@akien-mga
Copy link
Member

Merged manually in ef174ab.

@akien-mga akien-mga closed this Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants