Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationTreePlayer filters improved #5352

Merged
merged 1 commit into from Jul 10, 2016
Merged

AnimationTreePlayer filters improved #5352

merged 1 commit into from Jul 10, 2016

Conversation

m4nu3lf
Copy link
Contributor

@m4nu3lf m4nu3lf commented Jun 21, 2016

Now the AnimationTreePlayer filters for Blend2 and OneShot nodes
behave as expected, that is the main animation is not affected by
the secondary animation if the track is filterd out, for arbitarily
complex trees.

@akien-mga
Copy link
Member

akien-mga commented Jun 22, 2016

It seems to fail building with gcc/mingw:

scene/animation/animation_tree_player.cpp: In member function 'void AnimationTreePlayer::_process_animation(float)':

scene/animation/animation_tree_player.cpp:901:14: error: 'class Animation' has no member named 'value_track_is_continuous'

Now the AnimationTreePlayer filters for Blend2 and OneShot nodes
behave as expected, that is the main animation is not affected by
the secondary animation if the track is filterd out for arbitarily
complex trees.
@m4nu3lf
Copy link
Contributor Author

m4nu3lf commented Jun 22, 2016

Fixed but... Can't understand why that line has changed (or better hasn't changed) when I rebased my branch. I've got no collision and I am pretty sure I didn't change that line

@TheoXD
Copy link
Contributor

TheoXD commented Jul 2, 2016

Seems to be helping thanks! I had a soldier with a gun, and two blend2 nodes setup for aiming (one to blending from transition with walk cycle to aiming, overriding upper body) Second is for looking up and comes after, what happened was that my character stopped walking and lower body blended into idle (still aiming upwards though) so rather than walking and aiming up it was standing and aiming up. Your PR seems to have fixed the problem without me doing anything 👍

@m4nu3lf
Copy link
Contributor Author

m4nu3lf commented Jul 2, 2016

@TheoXD That is exactly the same problem I had. The whole filter functionality was substantially broken. Hopefully this will make into the official repo.

@reduz reduz merged commit 223ca13 into godotengine:master Jul 10, 2016
@akien-mga akien-mga added this to the 2.1 milestone Jul 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants