Allow declare the shader arrays with a size defined before identifier #53527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
shader_array
branch
8 times, most recently
from
acb0694
to
852e445
Compare
akien-mga
approved these changes
Oct 8, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly syntax sugar, but it's possible (in GLSL) to declare an array with the size defined before identifier eg:
int[2] arr;instead ofint arr[2];This PR makes it possible. To decrease code repetition - I've pushed the index parsing to a separate function.Note: It's already possible to do for varying/uniform arrays, this PR is for local arrays in functions and struct members.