Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip keyframe creation dialog when holding Shift in the animation editor #54524

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 2, 2021

The editor setting to always bypass the confirmation dialog was removed, since the new shortcut effectively supersedes it in a more granular way.

Preview

Not holding Shift at first, then holding Shift the second time.

animation-editor-skip-key-confirmation-dialog.mp4

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Nov 2, 2021
@Calinou Calinou added this to the 4.0 milestone Nov 2, 2021
@akien-mga akien-mga requested review from a team December 3, 2021 09:21
@KoBeWi
Copy link
Member

KoBeWi commented Jan 1, 2022

I wonder if it could be made more discoverable. Maybe the Key button could have a tooltip mentioning that Shift skips?

@akien-mga
Copy link
Member

I wonder if it could be made more discoverable. Maybe the Key button could have a tooltip mentioning that Shift skips?

That makes sense 👍

@YuriSizov
Copy link
Contributor

Should be good to merge after a rebase and if a note is added to the dialog itself that you can hold Shift to skip it.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 9, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@Calinou
Copy link
Member Author

Calinou commented Jul 17, 2023

Should be good to merge after a rebase and if a note is added to the dialog itself that you can hold Shift to skip it.

Done 🙂

image

@Calinou Calinou force-pushed the animation-editor-add-bypass-confirmation branch from 16fe279 to 4492990 Compare July 17, 2023 09:06
@YuriSizov
Copy link
Contributor

Docs need to be updated now that the setting has been removed.

The editor setting to always bypass the confirmation dialog was removed,
since the new shortcut effectively supersedes it in a more granular way.
@Calinou Calinou force-pushed the animation-editor-add-bypass-confirmation branch from 4492990 to 5e117ee Compare July 17, 2023 10:09
@Calinou Calinou requested a review from a team as a code owner July 17, 2023 10:09
@YuriSizov YuriSizov merged commit 3bc842b into godotengine:master Jul 26, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@securas
Copy link

securas commented Nov 10, 2023

Should be good to merge after a rebase and if a note is added to the dialog itself that you can hold Shift to skip it.

Done 🙂

image

I think that this is not enough. The user still presses the key in a setting in order to discover that it is necessary to press the shift key. As a result, it will always be a post-warning. There should be a pre-warning.
Alternatively, add a setting to remove this dialog window altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:animation topic:editor usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants