Fix ogg edge cases

[ellenhp]

This should fix the edge cases described in the comments of #55820. This PR needs testing and issues tracking each edge case to be created and linked before review/merging.

In its current state, this PR is just an attempt at simplifying some of the logic in the AudioStreamPlaybackResampled class and its Ogg implementation. A few things I was doing before that were error-prone have been removed. It's not perfect but I think it's a step in the right direction.

Bugsquad edit: Fix #55849, Fix #55848

[cstaavetti]

From just testing the code I can tell that it does indeed correctly play all the ogg files that previously failed to stop.
However I did notice that playing some mp3 files such as the included one do cause an error message

ERROR: Condition "!active" is true. Returning: 0
at: _mix_internal (modules/minimp3/audio_stream_mp3.cpp:41)

It still sounds correct and stops.
mp3error.zip

Looks like its because "if (is_playing()) {" was dropped and _mix_internal is called when the stream is no longer playing.

[ellenhp]

Oh good catch, I should make the same change to the MP3 stream. This change brings things more in line with the way I envisioned everything working when I did the audio server rewrite. The audio server attempts to mix a certain number of samples, and the stream playback can simply refuse to do the mix, if it's unable, which will cause the audio server to fade-out the playback to silence and then stop it completely.

[cstaavetti]

Ok, I see what you mean now, audio_stream_mp3.cpp should also return 0 when !active.
I read the current changes and in my opinion this PR does improve code quality and it does fix the related issues.
Once mp3's are fixed it should be ok, unless there is also some other format that needs updating.

[ellenhp]

Thanks! I'll update MP3 streams sometime today then get an official maintainer review after that. There does seem to be one last issue that I can only reproduce by selecting an ogg stream in the editor then clicking on the play/pause button as fast as I can. It's a crashing bug related to exhausting the ogg packet stream, then pausing, then playing. I'll make a new issue for it.

[fire]

When you're ready, post your pr for review. I'll try to gather the relevant parties.

[ellenhp]

I think this is ready now.

[akien-mga]

Thanks!

[bluenote10]

@ellenhp It looks like the change here (specifically to the AudioStreamPlaybackResampled::mix function) has broken the audio stream generator, which is a bit of a showstopper currently for migrating some music project to Godot 4. I did a small investigation and have a rough understanding why it is happening, but I lack the knowledge of the audio system and the idea behind this PR. If you are still around, it would be great to hear your opinion on some of the ideas I've laid out to fix it in #65155 (comment)!