[Headless] Workaround texture load failure. #56048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we still support pvrtc too? Might be good to double check all platforms' features to make sure we don't miss one. I think the workaround is correct for the time being. |
The PVRTC support code is still present, but I'm not sure if it still works in |
fire
reviewed
Dec 18, 2021
Some assets are loaded based on OS/server feature detection, namely textures (but potentially others). The ResourceImporter will fail to load a texture if the OS reports not supporting it. The OS, in turn, checks texture format support via the RenderingServer. This commit makes the dummy rasterizer report known texture formats as supported (although unused), so that scenes can be correctly loaded when they include references to imported textures.
Faless
force-pushed
the
headless/os_features
branch
from
075d39a
to
e880294
Compare
|
Added rgtc and bptc |
akien-mga
approved these changes
Dec 20, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some assets are loaded based on OS/server feature detection, namely textures (but potentially others).
The ResourceImporter will fail to load a texture if the OS reports not supporting it.
The OS, in turn, checks texture format support via the RenderingServer.
This commit makes the dummy rasterizer report known texture formats as supported (although unused), so that scenes can be correctly loaded when they include references to imported textures.
Fixes #55628 although this feels more like a workaround.
I'm not sure what a proper fix would look like, will probably have a better picture once we take a crack at: godotengine/godot-proposals#2756 (so we can re-export the assets in a dedicated format).
CC @akien-mga since I know you worked on the GL/OS texture format madness :)