Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port existing _notification code to use switch statements (part 1/3) #58163

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

jmb462
Copy link
Contributor

@jmb462 jmb462 commented Feb 16, 2022

Following #58151, the rest of the codebase should be given the same treatment to review all _notification methods and ensure that they use switch statements instead of a list of if (p_what == NOTIFICATION_*).

First chunk of #58155

editor/action_map_editor.cpp
editor/animation_bezier_editor.cpp
editor/animation_track_editor.cpp
editor/audio_stream_preview.cpp
editor/code_editor.cpp
editor/connections_dialog.cpp
editor/create_dialog.cpp
editor/debugger/debug_adapter/debug_adapter_server.cpp
editor/debugger/editor_debugger_inspector.cpp
editor/debugger/editor_debugger_node.cpp
editor/debugger/editor_debugger_tree.cpp
editor/debugger/editor_network_profiler.cpp
editor/debugger/editor_profiler.cpp
editor/debugger/editor_visual_profiler.cpp
editor/debugger/script_editor_debugger.cpp
editor/editor_about.cpp
editor/editor_audio_buses.cpp
editor/editor_autoload_settings.cpp
editor/editor_dir_dialog.cpp
editor/editor_export.cpp
editor/editor_feature_profile.cpp
editor/editor_file_dialog.cpp
editor/editor_file_system.cpp
editor/editor_help.cpp
editor/editor_help_search.cpp
editor/editor_inspector.cpp
editor/editor_log.cpp
editor/editor_node.cpp
editor/editor_path.cpp
editor/editor_plugin.cpp
editor/editor_plugin_settings.cpp
editor/editor_properties_array_dict.cpp
editor/editor_properties.cpp
editor/editor_resource_picker.cpp
editor/editor_run_native.cpp
editor/editor_settings_dialog.cpp
editor/editor_spin_slider.cpp
editor/editor_toaster.cpp
editor/editor_zoom_widget.cpp
editor/export_template_manager.cpp
editor/filesystem_dock.cpp
editor/find_in_files.cpp```

editor/code_editor.cpp Outdated Show resolved Hide resolved
editor/editor_help.cpp Outdated Show resolved Hide resolved
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A couple issues noted in comments but the rest seems good.

editor/editor_help.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit b5c0a89 into godotengine:master Feb 16, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants