Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix normals computation at the 'seam' of smoothed torus shape #59002

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix normals computation at the 'seam' of smoothed torus shape #59002

merged 1 commit into from
Mar 11, 2022

Conversation

MythTitans
Copy link
Contributor

Fix normals computation at seams of csg torus, the same way it was done for sphere and cylinder in #58208.

Before
torus_before

After
torus_after

@MythTitans MythTitans requested a review from a team as a code owner March 10, 2022 23:20
@MythTitans MythTitans mentioned this pull request Mar 10, 2022
Closed
@Calinou Calinou added this to the 4.0 milestone Mar 10, 2022
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.4 labels Mar 10, 2022
@akien-mga akien-mga merged commit c291b48 into godotengine:master Mar 11, 2022
@akien-mga
Copy link
Member

Thanks!

@MythTitans MythTitans deleted the fix-visible-seam-torus branch March 11, 2022 11:01
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 12, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MythTitans @akien-mga @Calinou