Disallow setting editor-only metadata in the editor #59969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
requested changes
Apr 19, 2022
|
Commited |
Calinou
approved these changes
May 4, 2022
There was a problem hiding this comment.
Looks good to me, please squash the commits together so we can merge this. See PR workflow for instructions 🙂
|
I force pushed a squash myself so that we can merge this PR (normally I wait longer to give original authors the chance to do it, but here I was doing a series of similar updates so I just did this one too :)). |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #59852
Metadata starts with
_considered as editor-only metadata and disallowed as mentioned in the issue.A bit sorry for Ayush-singla27, it has been 3 days and it really just need a few lines of code (or maybe Ayush already make a PR and I don't know how to use github). This is, too, my first contribution to me beloved game engine.
Bugsquad edit: