Fix normal and tangent blending in blend shapes #61217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with this code, but is there a way to describe what this fix does in a somewhat more verbose way? "Fix blend shapes" is pretty generic, does it really fix everything about blend shapes, or does it fix a specific bug in the blend shapes implementation that would be worth naming in the commit? |
WindyDarian
force-pushed
the
fix_blend_shapes
branch
from
6e5cc59
to
a3e016e
Compare
|
Changed to "Fix normal and tangent blending in blend shapes" |
WindyDarian
changed the title
reduz
approved these changes
May 20, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55812 for real now that i actually understood the blend shape math.
reduz was right in #60814 and tangent was wrong. With this #60814 is no longer needed