Add sky cover texture for PhysicalSkyMaterial #61478
Open
+45
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the previous night sky property with more flexible Sky Cover and Sky Cover Modulate properties. Like ProceduralSkyMaterial, this is designed to be used for night sky but also static cloud covering. However, unlike ProceduralSkyMaterial, sky cover in PhysicalSkyMaterial automatically takes atmospheric scattering into account for its coloring.
clayjohn
reviewed
Jun 28, 2022
| @@ -722,7 +738,8 @@ void sky() { | |||
| float sunAngularDiameterCos2 = cos(LIGHT0_SIZE * sun_disk_scale*0.5); | |||
| float sundisk = smoothstep(sunAngularDiameterCos, sunAngularDiameterCos2, cos_theta); | |||
| vec3 L0 = (sun_energy * 1900.0 * extinction) * sundisk * LIGHT0_COLOR; | |||
| L0 += texture(night_sky, SKY_COORDS).xyz * extinction; | |||
| // Multiply by 250 to compensate for color multiplication by 0.04 below and the default exposure (0.1). | |||
| L0 += (sky_cover_texture.rgb * sky_cover_modulate.rgb) * sky_cover_texture.a * sky_cover_modulate.a * extinction * 250.0; | |||
There was a problem hiding this comment.
Multiplying by 250 will make this way overbright when used as a night sky. For physical sky, it doesn't make as much sense to add cloud cover this way as clouds do not contribute direct lighting (like stars). Cloud cover belongs above with the other in scattering terms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #58018.
This replaces the previous night sky property with more flexible Sky Cover and Sky Cover Modulate properties.
Like ProceduralSkyMaterial, this is designed to be used for night sky but also static cloud covering. However, unlike ProceduralSkyMaterial, sky cover in PhysicalSkyMaterial automatically takes atmospheric scattering into account for its coloring.
Testing project: test_night_sky_2.zip
Preview
Dusk
Duskier
Duskiest