GDScript: Do not reset return value in release build #62317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 23, 2022
There was a problem hiding this comment.
Makes sense to me that the return value should actually be retrieved.
The comment makes it sounds like it was only intended in case of error/failure while this seems to be used also in non-failing cases, so the comment might need to be changed or maybe this is not in the right place.
CC @vnen
Edit: I misread, this makes the retvalue only be assigned in debug which is consistent with what the comment says. Seems sensible.
akien-mga
changed the title
akien-mga
approved these changes
Jun 23, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59239
Reset return value on error only in debug builds. Right now there is no mechanism in release build to know if there was error or not.