Add ability to rename groups in the GroupsEditor #62659
Conversation
Chaosus
force-pushed
the
editor_group_rename_option
branch
from
6f254ed
to
881370c
Compare
| @@ -217,19 +217,14 @@ void GroupDialog::_add_group_text_changed(const String &p_new_text) { | |||
| } | |||
|
|
|||
| void GroupDialog::_group_renamed() { | |||
| TreeItem *renamed_group = groups->get_edited(); | |||
| TreeItem *renamed_group = groups->get_selected(); | |||
There was a problem hiding this comment.
This was changed to prevent bug:
Chaosus
force-pushed
the
editor_group_rename_option
branch
from
881370c
to
54ea4fc
Compare
|
We discussed this in a PR review meeting, and there's one issue with this approach. The group dialog (which you get when clicking "Manage Groups") lets you modify groups for all nodes in these groups, so when renaming a group there, it gets renamed for all nodes. While this PR changes the Node-specific group dock, and renaming a group there should not affect other nodes. So this should be changed to only change the group for the selected Node (i.e. creating a new group instead of renaming an existing one that might be shared by others). |
Chaosus
force-pushed
the
editor_group_rename_option
branch
from
54ea4fc
to
2efbba7
Compare
|
@akien-mga Done, I think |
Chaosus
force-pushed
the
editor_group_rename_option
branch
from
2efbba7
to
1b1f0de
Compare
|
There is a bug that happens when you rename a group from an inherited scene: |
Chaosus
force-pushed
the
editor_group_rename_option
branch
from
1b1f0de
to
8075adc
Compare
|
@KoBeWi ah, it's just rebasing - I thought you've fixed a bug :) |
|
@KoBeWi that bug is not related to this PR (at least directly). |
|
Thanks! |
QoL change to the Groups editor:
Previously user must press
Manage Groupsto call the dialog to change it. I didnt checked how it would interact with #60965. If that PR would superseeds it, that would be good, if not, it can be used on its own.Also added a check to prevent redundanly calling
create_action(TTR("Rename Group"));if the group name was unchanged.