Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csg boolean operators using elalish/manifold. #62985

Closed
wants to merge 1 commit into from

Conversation

fire
Copy link
Member

@fire fire commented Jul 13, 2022

Fixes: godotengine/godot-proposals#2271

See also godotengine/godot-proposals#2759 and godotengine/godot-proposals#4448.

Wanted to get this shown so people can review and get in progress.

  • The dependencies of thrust, google test and glm are excessive. Trying to think of a way to reduce them.
  • Materials are incorrectly copied to the other csg brush.
  • Many cases cause the manifold check to turn the mesh empty.
  • All godot internal csg brushes must be manifold. I believe the sphere and the torus needs to be checked.

@Calinou
Copy link
Member

Calinou commented Jul 13, 2022

The dependencies of thrust, google test and glm are excessive. Trying to think of a way to reduce them.

Can we import the library without the unit tests? We won't be running them, as we don't run third-party library tests in general.

@fire fire force-pushed the csg-manifold branch 7 times, most recently from 807c297 to 3e065dd Compare July 22, 2022 19:13
@fire fire force-pushed the csg-manifold branch 17 times, most recently from ba87192 to 524b627 Compare August 4, 2022 04:16
Check if the results are manifold.
@fire fire modified the milestones: 4.0, 4.x Aug 24, 2022
@fire
Copy link
Member Author

fire commented Aug 20, 2023

The code increase is a lot and I couldn't justify the complexity. The csg is godot has been mended, but it still has cases that fail. The manifold library is still good.

I'd say this is salvagable.

@fire fire closed this Aug 20, 2023
@AThousandShips AThousandShips removed this from the 4.x milestone Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect CSG Missing Triangles & Spike Triangles
3 participants