Ask before closing with unsaved resources

[KoBeWi]

Fixes #45612

If none of the scenes have unsaved changed, but the global history is unsaved, a unique dialog appears:

[akien-mga]

Could maybe use a local bool instead of using a new magic number in an unrelated index?

[KoBeWi]

It can't be a local bool, because the value is also used elsewhere. Re-using the variable was simpler to do and is less error-prone than adding a new variable and making sure it's used where necessary.

[akien-mga]

But outside this scope, does it serve a purpose and is it properly handled that tab_closing_idx stays -2?

What I meant with a local bool would be this:

tab_closing_idx = _next_unsaved_scene(false);
bool ext_res_only = false;
if (tab_closing_idx == -1) {
	ext_res_only = true;
} else {
	_scene_tab_changed(tab_closing_idx);
}

[KoBeWi]

Yes, here:

godot/editor/editor_node.cpp

Lines 1958 to 1960 in 8b79a19

	if (scene_idx != -1) {
	_discard_changes();
	}

[akien-mga]

That's pretty smelly :(

But well, I guess this can be revisited in the future.

[akien-mga]

Thanks!