Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS extend-to-title] Add scene/project name to the editor title, and fix window button placement. #66254

Merged
merged 1 commit into from Sep 23, 2022
Merged

[macOS extend-to-title] Add scene/project name to the editor title, and fix window button placement. #66254

merged 1 commit into from Sep 23, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 22, 2022

  • Implements UX/UI: Adding Application > Config > Name to titlebar godot-proposals#5442
  • Fixes incorrect window button position and order when system primary language is right-to-left (should be mirrored and on the right side of titlebar).
  • Improve full-screen transition animation and add titlebar_changed signal to the Window to handle full-screen transition or extend-to-title changes.

Screenshot 2022-09-22 at 14 05 22

@bruvzg bruvzg added this to the 4.0 milestone Sep 22, 2022
@bruvzg bruvzg marked this pull request as ready for review September 22, 2022 17:57
@bruvzg bruvzg requested review from a team as code owners September 22, 2022 17:57
@bruvzg
[macOS extend-to-title] Add scene/project name to the editor title, f…
0dab11a 
…ix incorrect window button position/order when system primary language is RTL.
@akien-mga akien-mga merged commit 3a8e711 into godotengine:master Sep 23, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the macos_title branch September 23, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug enhancement platform:macos topic:gui topic:porting
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bruvzg @akien-mga