Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simplify_path() breaking uid:// #67131

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Fix simplify_path() breaking uid:// #67131

merged 1 commit into from
Oct 10, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 9, 2022 •
edited
Loading

Fixes #63703
It was changing uid://something to uid:/something.

I also removed unnecessary s.length() usage (substr() uses remainder by default).

@KoBeWi KoBeWi added this to the 4.0 milestone Oct 9, 2022
@KoBeWi KoBeWi requested a review from a team as a code owner October 9, 2022 12:23
@akien-mga akien-mga merged commit bfffc06 into godotengine:master Oct 10, 2022
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the simplify_the_simplify branch October 10, 2022 09:03
@akien-mga akien-mga mentioned this pull request Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

preload(uid) gives Preload file does not exist
2 participants
@KoBeWi @akien-mga