Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if Vulkan context for the window exists before resizing it to avoid unnecessary error messages. #67539

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Check if Vulkan context for the window exists before resizing it to avoid unnecessary error messages. #67539

merged 1 commit into from
Oct 17, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 17, 2022

Fixes #67408, resize event can be triggered during window creation (before Vulkan context for a window is initialized).

@bruvzg bruvzg added this to the 4.0 milestone Oct 17, 2022
@bruvzg bruvzg requested a review from a team as a code owner October 17, 2022 14:28
@akien-mga akien-mga merged commit b545d55 into godotengine:master Oct 17, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the check_ctx branch October 17, 2022 15:45
@lmurray lmurray mentioned this pull request Oct 22, 2022
Closed
@amb amb mentioned this pull request Oct 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:porting
Projects
None yet
Milestone
4.0
2 participants
@bruvzg @akien-mga